fix(client): guard against dotless qualified_name in _setup_instrumentation#6452
Merged
sentrivana merged 2 commits intoJun 1, 2026
Conversation
…tation
When a functions_to_trace entry's qualified_name contains no dot, the
rsplit(".", 1) unpacking at line 510 raised ValueError outside the
surrounding try/except, crashing sentry_sdk.init() entirely. Add an
early check that skips the entry with a warning instead.
Fixes getsentry#6451
sentrivana
approved these changes
Jun 1, 2026
…sdk-initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
Passing a
functions_to_traceentry whosequalified_namehas no dot (e.g.{"qualified_name": "my_function"}) crashessentry_sdk.init()with an unhandledValueError. The SDK never initializes and the user gets a hard traceback instead of a warning.Why it happens
The
rsplit(".", 1)unpacking on line 510 sits before thetry/exceptblock that begins on line 512. Whenqualified_namecontains no dot, the list has one element, the two-target unpacking fails, and theValueErrorpropagates out of__init__uncaught.Fix
Added a guard before the
rsplitcall: if"."is not infunction_qualname, log a warning andcontinueto the next entry. The user gets a clear message to use a fully qualified name (e.g.mymodule.my_function) and SDK init proceeds normally.Test
test_functions_to_trace_no_dot_does_not_crash— verifies thatsentry_sdk.init()with a dot-freequalified_namecompletes without raising.Fixes #6451